htwangtw / adie_ongoingthoughts

ADIE ongoing thought related analysis plan
MIT License
1 stars 2 forks source link

Experience sampling #12

Closed htwangtw closed 3 years ago

htwangtw commented 3 years ago

I accidentally merged things again

sourcery-ai[bot] commented 3 years ago

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 5.20%.

Quality metrics Before After Change
Complexity 3.76 ⭐ 3.20 ⭐ -0.56 👍
Method Length 58.43 ⭐ 50.25 ⭐ -8.18 👍
Working memory 12.77 😞 11.32 😞 -1.45 👍
Quality 64.26% 🙂 69.46% 🙂 5.20% 👍
Other metrics Before After Change
Lines 184 216 32
Changed files Quality Before Quality After Quality Change
adie/init.py % % %
adie/bids.py 79.71% ⭐ 78.31% ⭐ -1.40% 👎
adie/nback.py 84.45% ⭐ 80.44% ⭐ -4.01% 👎
adie/scripts/beh2bids.py 51.19% 🙂 51.19% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
adie/scripts/beh2bids.py main 10 🙂 233 ⛔ 25 ⛔ 32.01% 😞 Try splitting into smaller methods. Extract out complex expressions
adie/scripts/beh2bids.py check_session 2 ⭐ 79 🙂 10 😞 70.01% 🙂 Extract out complex expressions
adie/nback.py _get_probe_time 0 ⭐ 56 ⭐ 11 😞 73.64% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.