Closed easyhappy closed 5 years ago
Merging #126 into master will decrease coverage by
21.94%
. The diff coverage is58.33%
.
@@ Coverage Diff @@
## master #126 +/- ##
===========================================
- Coverage 97.61% 75.66% -21.95%
===========================================
Files 11 11
Lines 335 337 +2
===========================================
- Hits 327 255 -72
- Misses 8 82 +74
Impacted Files | Coverage Δ | |
---|---|---|
lib/rails-settings/scoped_settings.rb | 75% <33.33%> (-25%) |
:arrow_down: |
lib/rails-settings/settings.rb | 77.61% <66.66%> (-20.88%) |
:arrow_down: |
spec/rails-settings-cached/default_setting_spec.rb | 63.41% <0%> (-36.59%) |
:arrow_down: |
lib/rails-settings/base.rb | 73.52% <0%> (-26.48%) |
:arrow_down: |
lib/rails-settings/default.rb | 71.42% <0%> (-25%) |
:arrow_down: |
spec/rails-settings-cached/setting_spec.rb | 77.86% <0%> (-22.14%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 848baa6...d522866. Read the comment docs.
主要是修复 线程安全问题
测试代码:
修复前: 运行代码后 会发现 items_1.uniq 和 items_2.uniq 都会包含
修复后: 就不会交叉到一起了