search

huacnlee / rails-settings-cached

Global settings for your Rails application.
Other
1.06k stars 202 forks source link

Update rubocop dev dependency to `~>0.51` #134

Closed iarie closed 5 years ago

iarie commented 6 years ago

minor style changes and gems updates

codecov[bot] commented 6 years ago

Codecov Report

Merging #134 into master will decrease coverage by 16.71%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #134       +/-   ##
===========================================
- Coverage   97.61%   80.89%   -16.72%     
===========================================
  Files          11       11               
  Lines         335      335               
===========================================
- Hits          327      271       -56     
- Misses          8       64       +56
Impacted Files Coverage Δ
lib/rails-settings/settings.rb 89.39% <100%> (-9.1%) :arrow_down:
lib/rails-settings/default.rb 64.28% <100%> (-32.15%) :arrow_down:
lib/rails-settings/railtie.rb 100% <100%> (ø) :arrow_up:
spec/rails-settings-cached/default_setting_spec.rb 63.41% <0%> (-36.59%) :arrow_down:
spec/rails-settings-cached/setting_spec.rb 81.14% <0%> (-18.86%) :arrow_down:
lib/rails-settings/base.rb 91.17% <0%> (-8.83%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 36bf1b6...421f4cf. Read the comment docs.