search

huacnlee / rails-settings-cached

Global settings for your Rails application.
Other
1.06k stars 202 forks source link

Split single app.yml into separate files under config/settings #138

Closed evgeny-danilov closed 6 years ago

evgeny-danilov commented 6 years ago

I propose to split app.yml into separate files because sometimes it can be very huge, if you have hundreds of keys your app.yml will become a total mess, anyway scope dividing it's a good practice like dotenv etc. Based on this discussion: https://github.com/huacnlee/rails-settings-cached/pull/132

codecov[bot] commented 6 years ago

Codecov Report

Merging #138 into master will increase coverage by <.01%. The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage   97.57%   97.58%   +<.01%     
==========================================
  Files          11       11              
  Lines         330      331       +1     
==========================================
+ Hits          322      323       +1     
  Misses          8        8
Impacted Files Coverage Δ
spec/rails-settings-cached/default_setting_spec.rb 100% <100%> (ø) :arrow_up:
lib/rails-settings/settings.rb 98.48% <50%> (ø) :arrow_up:
lib/rails-settings/default.rb 95.83% <85.71%> (+0.18%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f74278...c643abd. Read the comment docs.