search

huacnlee / rails-settings-cached

Global settings for your Rails application.
Other
1.06k stars 202 forks source link

Version2... #159

Closed kenzooooo closed 5 years ago

kenzooooo commented 5 years ago

I want to manage in the file like the previous version. I want you to do this as another gem

huacnlee commented 5 years ago

You can keep use the 0.x version, I will still maintain it.

And you can try the new version in the new project, the 2.x design is simple, and better.

wflanagan commented 5 years ago

So, FYI.. related to this. A regular bundle on your gem bumped it to v2, which BROKE Heroku deploys to production. We didn't receive anything in the way of a DEPRECATION warning that said the upgrade would break (at least that I saw), and had a tense hour this morning while we figured out what was going on (as it looked more like an ActiveRecord database connectivity problem).

I get and appreciate the desire to move forward, but I do think that some warning that you're doing breaking changes would be helpful.

And, as always with these things, I'm truly appreciative that this is open source and you've shared your work. Thank you.