search

huacnlee / rails-settings-cached

Global settings for your Rails application.
Other
1.06k stars 202 forks source link

Improve setting to support Float and BigDecimal #187

Closed sangnguyen1001 closed 4 years ago

sangnguyen1001 commented 4 years ago

Hi @huacnlee , this PR is the update of https://github.com/huacnlee/rails-settings-cached/pull/180. I have just created new PR and revert the Gemfile.lock. Plz help me to merge this PR

codecov[bot] commented 4 years ago

Codecov Report

Merging #187 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #187   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           11        13    +2     
=========================================
+ Hits            11        13    +2
Impacted Files Coverage Δ
test/models/setting.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8c5d299...845be7a. Read the comment docs.