search

huacnlee / social-share-button

Helper for add social share feature in your Rails app. Twitter, Facebook, Weibo, Douban ...
MIT License
582 stars 311 forks source link

Undocumented jQuery dependency. #142

Open yxhuvud opened 7 years ago

yxhuvud commented 7 years ago

There is a dependency on jquery to get this to work, and not only jquery, but that you let jquery define $ in the global scope. This dependency should either be documented or removed.

vanessasoutoc commented 6 years ago

How is dependency, not work for me!

hjJunior commented 6 years ago

To make this work, I supposed to add jquery

Gem file

gem 'jquery-rails'

Application.js

And here we need to load the jquery.js

//= require jquery3
//= require jquery_ujs
//= require social-share-button
...

` Maybe this tutor could help u better: Using Jquery with Rails

chrisjeon commented 5 years ago

Can someone make a PR to remove this jQuery dependency? It's 2019.