Closed FrankelJb closed 4 years ago
a few observations indicate to us that this code change is correct and the note on the README is wrong, perhaps the only problem is when #{desc} is an empty string
to preserve the existing functionality maybe something like this
http://www.facebook.com/sharer/sharer.php?u=#{url}&display=popup#{(""e=" + desc) if desc}
It work's fine without extra space. Does it affect any other shares?
desc = encodeURIComponent($parent.data("desc") || '')
Any news about this?
this seem inconsistent with note left on README here: https://github.com/huacnlee/social-share-button#facebook-needs-the-description-added
we were assuming the requirement is on Facebook's end? this code assumes this is not true and FB does not require the description