search

huacnlee / social-share-button

Helper for add social share feature in your Rails app. Twitter, Facebook, Weibo, Douban ...
MIT License
582 stars 309 forks source link

Jfb/many opts for different output #161

Closed jasonfb closed 6 years ago

jasonfb commented 6 years ago

@huacnlee -- we want this gem to be able to produce icons that look different. specifically, we want font-awesome icons.

I did some work here adding several non-required options to make it possible to pass font-awesome specific options to this gem.

do you like this idea?

huacnlee commented 6 years ago

If you don't want use default style, you can write your custom social_share_button_tag helper to generate html for your self.

So I can't accept this PR, because this gem want keep one way to use, sorry.

jasonfb commented 6 years ago

Yes, we realize the PR does significantly deviate the API of your base code. We will consider an alternative option.