Remove jQuery usage. Add viadeo support.

huacnlee / social-share-button

Helper for add social share feature in your Rails app. Twitter, Facebook, Weibo, Douban ...

MIT License

582 stars 309 forks source link

Remove jQuery usage. Add viadeo support. #168

Closed dm67x closed 5 years ago

dm67x commented 6 years ago

I removed jQuery inside the main code (social-share-button.coffee) to use this plugin without jQuery (but you need to use jQuery to have wechat support, due of jquery.qrcode plugin). And I added support for viadeo.

huacnlee commented 6 years ago

Please split difference features into 2 PR.

Remove jQuery is ok, but viadeo I don't want accept it.

nfedyashev commented 5 years ago

@huacnlee

jQuery dependency has been removed in 8bbb044eb1aa1113432daa7ac4584782888fb2c3 You decided not to accept Viadeo so this PR should be closed, right?