Use setproctitle() on FreeBSD so that display-name works for daemon processes.

huadaonan / modwsgi

Automatically exported from code.google.com/p/modwsgi

0 stars 0 forks source link

Use setproctitle() on FreeBSD so that display-name works for daemon processes. #90

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

See:

  http://www.freebsd.org/cgi/query-pr.cgi?pr=125628

Really don't understand why people doing ports can't be bothered to report 
changes to original 
developers. :-(

Original issue reported on code.google.com by Graham.Dumpleton@gmail.com on 15 Jul 2008 at 1:11

GoogleCodeExporter commented 8 years ago

Original comment by Graham.Dumpleton@gmail.com on 15 Jul 2008 at 1:47

Added labels: Type-Enhancement
Removed labels: Type-Defect

GoogleCodeExporter commented 8 years ago

Change made in revisions 951.

Original comment by Graham.Dumpleton@gmail.com on 15 Jul 2008 at 1:54

Changed state: Started
Added labels: Milestone-Release3.0

GoogleCodeExporter commented 8 years ago

Hello,

I'm the port maintainer for mod_wsgi on FreeBSD and I received that patch last 
night.
I got around to checking on it today and fixed it up a bit before sending my 
approval
to FreeBSD. Anyway, I was about to send my fixed up patch to you when I 
discovered
this. :) So I've attached my fixed up patch.

Original comment by douglaswth on 15 Jul 2008 at 9:57

Attachments:

patch-mod_wsgi.c

GoogleCodeExporter commented 8 years ago

Oh, and according to the manpage for setproctitle(3) it may also work on other 
BSDs.

http://www.freebsd.org/cgi/man.cgi?query=setproctitle

Original comment by douglaswth on 15 Jul 2008 at 10:02

GoogleCodeExporter commented 8 years ago

Support for NetBSD and OpenBSD added at revision 963. Backported to 2.2 in 
revision 965.

Original comment by Graham.Dumpleton@gmail.com on 6 Aug 2008 at 10:20

GoogleCodeExporter commented 8 years ago

Original comment by Graham.Dumpleton@gmail.com on 6 Aug 2008 at 10:21

Added labels: Milestone-Release2.2
Removed labels: Milestone-Release3.0

GoogleCodeExporter commented 8 years ago

All three of the man pages for setproctitle specify that it should be called 
with a
format and then the data just like the printf family of functions. My patch also
eliminates warnings about the unused variables in the beginning of the function.

Original comment by douglaswth on 22 Aug 2008 at 11:05

Attachments:

patch-mod_wsgi.c

GoogleCodeExporter commented 8 years ago

Hmmm, original poster didn't mentioned this from memory. Will have to fix it to 
use appropriate calling 
sequence else someone putting % formatters in it could cause it to crash 
process. Thanks.

Original comment by Graham.Dumpleton@gmail.com on 23 Aug 2008 at 4:52

GoogleCodeExporter commented 8 years ago

Damn, original patch did use %s, because I did change later, must have 
forgotten. :-(

Original comment by Graham.Dumpleton@gmail.com on 23 Aug 2008 at 5:47

GoogleCodeExporter commented 8 years ago

New issue fixed in version 2.3.

Original comment by Graham.Dumpleton@gmail.com on 23 Aug 2008 at 1:49

Added labels: Milestone-Release2.3
Removed labels: Milestone-Release2.2

GoogleCodeExporter commented 8 years ago

Version 2.3 release which hopefully now fixes all BSD issues for this.

Original comment by Graham.Dumpleton@gmail.com on 24 Aug 2008 at 5:57

Changed state: Fixed