huadaonan / mysql-master-ha

Automatically exported from code.google.com/p/mysql-master-ha
0 stars 0 forks source link

Plaintext password in output #99

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Run masterha_master_switch
2. Look at output of MHA when it runs the 
/usr/local/bin/mha_master_ip_online_change or 
/usr/local/bin/mha_master_ip_failover script

What is the expected output? What do you see instead?

Other places in the code, passwords are replaced with 'xxx' for logging, but 
this is not the case here. Instead, you see the actual password.

What version of the product are you using?

This is present in version 0.56.

Please provide any additional information below.

I've attached two patch files. One for MasterFailover.pm and one for 
MasterRotate.pm which fix the issue.

Original issue reported on code.google.com by jonahber...@gmail.com on 14 Oct 2014 at 10:23

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks Jonah. Your patch looks good. Would you mind if submitting a pull 
request on GitHub repo https://github.com/yoshinorim/mha4mysql-manager ?

- Yoshinori

Original comment by Yoshinor...@gmail.com on 15 Oct 2014 at 4:53

GoogleCodeExporter commented 9 years ago
Pull request submitted. https://github.com/yoshinorim/mha4mysql-manager/pull/48

Original comment by jonahber...@gmail.com on 16 Oct 2014 at 7:48

GoogleCodeExporter commented 9 years ago
Done. Thanks for your contribution!

Original comment by Yoshinor...@gmail.com on 17 Oct 2014 at 6:46