huahouye / jupiter-eclipse-plugin

Automatically exported from code.google.com/p/jupiter-eclipse-plugin
1 stars 1 forks source link

I cannot use it to review sql scripts #42

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Opened a sql file in eclipse
2. Selected a line where I want to add a code review comment. I don't have
option in the right click menu to add a review Issue.
3. If I add the review manually(from review table) is not remembering the
file/line where I added the issue.

What is the expected output? What do you see instead?
See a marker where the review was added even if it's a sql script. Also
when I click on the review issue to go in the sql script at that line.

Please use labels and text to provide additional information.

Original issue reported on code.google.com by adrian.c...@gmail.com on 4 Sep 2008 at 7:46

GoogleCodeExporter commented 8 years ago
It would help if you mentioned what version of Eclipse you're using and what 
editor
you're using.  Because as far as I know the default Eclipse installation opens 
sql
scripts with the Text Editor, which does have the option to add a review issue.

Adding a review from the review table does not tie the issue to a line in the 
code.

Jupiter currently ONLY contributes to the Java and Text editors.  We haven't 
found a
solution to contributing to editors we don't know about.  This issue will 
probably be
fixed when Issue 24 gets addressed.

Original comment by jsakuda on 4 Sep 2008 at 9:03

GoogleCodeExporter commented 8 years ago
I'm using Eclipse 3.4 and the sql files are opened with Sql File Editor(which 
in my
case is the default editor because I have in my bundle the Eclipse Data Tools). 

Original comment by adrian.c...@gmail.com on 4 Sep 2008 at 9:11

GoogleCodeExporter commented 8 years ago

Original comment by jsakuda on 2 Dec 2008 at 1:41

GoogleCodeExporter commented 8 years ago

Original comment by jsakuda on 5 Jun 2009 at 6:37