huajun07 / codesketcher

Visualise your code in action!
https://main.d1fr5et3wgts3j.amplifyapp.com/
MIT License
0 stars 0 forks source link

Feat/backend improvement #27

Closed limanjun99 closed 1 year ago

limanjun99 commented 1 year ago

This PR upgrades the executor service so that it doesn't crash as much (e.g. when handling code that cannot be serialised to JSON). Tested with dev environment (https://feat-backend-improvement.d1fr5et3wgts3j.amplifyapp.com/).

Done:

Future Work:

limanjun99 commented 1 year ago

Overall LGTM. Some concerns:

  1. As shown in the image below the value of b is not displayed even when the execution was finished (Please look into this bug before approval) image
  2. The wrong execution message is displayed when there are too many executions due to time limit exceeded (Please raise an issue for this) image

The cause for issue 1 has been identified, raised an issue for it (and a related issue as well).

Issue 2 will be fixed in a future PR.