Allow for setting any Postfix variables in the config file (both main.cf and master.cf)

huan / docker-simple-mail-forwarder

Simplest and Smallest Email Forward Service based on Docker.

https://hub.docker.com/r/zixia/simple-mail-forwarder/

Apache License 2.0

544 stars 88 forks source link

Allow for setting any Postfix variables in the config file (both main.cf and master.cf) #93

Closed dgraziotin closed 3 years ago

dgraziotin commented 3 years ago

As presented in #92, this PR enables SMF to recognize environment variables that start with SMFPOSTFIXMAIN and SMFPOSTFIXMASTER to set option entries for postfix main.cf and master.cf, respectfully.

Provided in this PR:

Functionality
Tests
Updated README.md

dgraziotin commented 3 years ago

@huan I know the drill, but I do not know who to call to review this one :-) care to name a good reviewer? Thanks!

huan commented 3 years ago

@dgraziotin Thank you very much for taking this new feature and create this great PR with docs & unit tests!

I feel it's good, please try to get at least one more approval from any SMF users then I'll be very confident to merge this PR!

dgraziotin commented 3 years ago

@huan thanks! Unfortunately, I am not familiar with SMF users and would like to avoid asking again to the same one (not even tagging them here 😄). Would you have any suggestions?

huan commented 3 years ago

Ok, let's merge this PR for now, and please test it and make sure the published image works as expected.

Thanks for the contribution, appreciate it!

dgraziotin commented 3 years ago

Thanks @huan! I have SMF in production on 3 servers and make use of this feature. I will certainly test it over time and come back here with bug fixes, in case!