search

huan / docker-simple-mail-forwarder

Simplest and Smallest Email Forward Service based on Docker.
https://hub.docker.com/r/zixia/simple-mail-forwarder/
Apache License 2.0
544 stars 88 forks source link

Update README.md on DockerHub schedule? #94

Open thexperiments opened 3 years ago

thexperiments commented 3 years ago

Hi,

when will the latest version be pushed to docker hub? I would need the ability to modify postfix configurations but what is on docker hub seems quite a bit older than what is here on github although it wa supdated 16 days ago.

Thanks

huan commented 3 years ago

I believe the docker hub version is the latest master branch code at this repo, because the GitHub Actions have ran the deploy and it's green.

See: https://github.com/huan/docker-simple-mail-forwarder/actions

If it's not, please provide some additional information so that we can check.

thexperiments commented 3 years ago

When looking at the information at https://hub.docker.com/r/zixia/simple-mail-forwarder/ my guess is that it should be the identical to the Readme.md here.

However it is missing the complete "custom configuration postfix" part and version history stops at 1.1.

I did not yet have the chance to compare the image contents.

huan commented 3 years ago

Please check https://github.com/huan/docker-simple-mail-forwarder/blob/master/VERSION and compare it to the docker container that you run for getting to know if your version is the latest.

thexperiments commented 3 years ago

That file is not copied in the Dockerfile so I can't check it in the image unfortunately. However the changes from: https://github.com/huan/docker-simple-mail-forwarder/commit/6c15313b77024811d3a1363dcec9654d6aa2cd46 seem to be present in the image.

Maybe there would be an additional action needed to update the dockerhub "Readme.md" so that it also is up to date?

huan commented 3 years ago

Thanks for pointing this out!

Yes, we need an additional action to update the dockerhub Readme.md.

See: https://stackoverflow.com/questions/29134275/how-to-push-a-docker-image-with-readme-file-to-docker-hub

thexperiments commented 3 years ago

Ok so the image seems to be up to date and I can use the functionality I need when referring to the github README.md for usage.

Shall this stay open as a "task" for adding the necessary action for the Readme update or will you create an extra issue for that?

huan commented 3 years ago 
$ docker pushrm zixia/docker-simple-mail-forwarder
ERRO error pushing readme to repo server. See error message below. Run with "--debug" for more details. 

error pushing README, bad status code for response: 403 FORBIDDEN. Server responded: "access to the resource is forbidden with personal access token". Try "docker logout" and "docker login". You cannot use a personal access token to log in and must use username and password. If you have 2FA auth enabled in Dockerhub you'll need to disable it for this tool to work. (This is an unfortunate Dockerhub limitation, see docs for more info.)

I have tried to use pushrm but it seems that the docker hub personal access token is not supported.

Let's keep this issue open for adding the necessary action for the Readme update.

huan commented 3 years ago

For now, I have just updated the README.md on DockerHub by hand with the latest version in this repo.