search

huan / docker-simple-mail-forwarder

Simplest and Smallest Email Forward Service based on Docker.
https://hub.docker.com/r/zixia/simple-mail-forwarder/
Apache License 2.0
544 stars 86 forks source link

Change Postfix logging configuration tests behaviour #99

Closed tamaro-skaljic closed 3 years ago

tamaro-skaljic commented 3 years ago

48

tamaro-skaljic commented 3 years ago

@huan The tests were not a problem in the build pipeline before. However, @cenk1cenk2 ran the tests locally in his terminal. As a result, the variable was overwritten in his terminal session, leading to unexpected behaviour afterwards. Namely, Postfix logs to a file that he did not specify. By introducing this global variable, the value that was in the variable before the test execution is now restored at the end of the test execution. So no, removing this global variable would cause this unexpected behaviour to occur again. Moving it to one of the @Test blocks would be possible, but would have no effect on anything except that it would be in a different line.

huan commented 3 years ago

Ok, thanks for the explaination.

Let's merge it for now, and if there are any improvement we could make it better, let's continue improving it.