huan / docker-wechat

DoChat is a Dockerized WeChat (盒装微信) PC Windows Client for Linux
https://hub.docker.com/r/zixia/wechat
Apache License 2.0
2.23k stars 199 forks source link

use $USER macro instead of hardcoding directory #195

Closed Lander-Hatsune closed 8 months ago

Lander-Hatsune commented 1 year ago

see #165

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

etoyz commented 11 months ago

/home/user/WeChat Files/ 对应的不是宿主机目录而是容器内部目录,硬编码没问题的,你这样一改相当于把容器内部一个不存在的目录挂载到宿主机的$HOME/DoChat/WeChat Files/上,没有意义而且失去了持久化

huan commented 8 months ago

I agree with @etoyz .

So, I'll close this PR for now.

@Lander-Hatsune please feel free to continue discussing the issue if you have any future thoughts.