search

huangp / entityunit

Simple tool to make JPA entities for testing
GNU Lesser General Public License v2.1
0 stars 2 forks source link

Entityunit tries to use field names as property names #4

Open seanf opened 7 years ago

seanf commented 7 years ago

The method BeanMaker.trySetValue() calls BeanUtils.setProperty if the JPA AccessType is PROPERTY, but it uses a field name instead of a property name. To make things worse, it seems that org.apache.commons.beanutils.BeanUtils.setProperty() fails silently if the requested property doesn't exist. This leaves the entity property with its default value, instead of setting the requested value.

This interacts badly with Kotlin's approach to interop for boolean properties - a Boolean Kotlin property named isActive will be exposed with the getter isActive() and the setter setActive() (thus the JavaBean property name is active), but the backing field is named isActive, not active. This is perfectly valid for JavaBeans, and would not be a problem, except that entityunit tries to access the JavaBean property (active) using the field name (isActive).

seanf commented 7 years ago

I noticed that entityunit also had trouble finding the specified values for constructor parameters when first building the entity. Since every JPA entity or JavaBean should have a zero-param constructor, it's probably safer to use it and then fill in all the fields/properties (since they have names; constructor parameters generally haven't, unless you use @java.beans.ConstructorProperties).