huangyh09 / brie

BRIE: Bayesian Regression for Isoform Estimate in Single Cells
https://brie.readthedocs.io
Apache License 2.0
41 stars 15 forks source link

brie seems to be incompatible with python3 #12

Closed RuyBlast closed 5 years ago

RuyBlast commented 6 years ago

Hello Yuanhua,

I built brie from source using python3 and I ended up with the error TypeError: object of type 'map' has no len() trying to run the brie-event command line. I built again brie with python2 and all went fine. Are you sure brie is compatible with python3 ? If not maybe you should write it on the readme and the website. (or fix it but it may be complicated)

Also, there is a typo in the brie website at https://brie-rna.sourceforge.io/manual.html the command line example brie-event-filter -a AS_events/SE.gff3 -anno_ref gencode.vM12.annotation.gtf -r GRCm38.p5.genome.fa is false and does not run, it should be replaced by: brie-event-filter -a AS_events/SE.gff3 --anno_ref=gencode.vM12.annotation.gtf -r GRCm38.p5.genome.fa

Best, Milan

huangyh09 commented 6 years ago

Hi Milan,

Many thanks for reporting this. You are right that the brie-event are not compatible with Python3 well. This is because the codes for generating splicing events are borrowed from Yaden's repo: https://github.com/yarden/rnaseqlib, and it is not easy to fully adapte these codes from Python2 to Python3.

I will add comments in the readme file and the manual, before correcting it.

Thanks Yuanhua