huangyh09 / briekit

Preprocessing tool kit of BRIE project in splicing analysis
https://brie.readthedocs.io/en/latest/briekit.html
Apache License 2.0
2 stars 2 forks source link

Missing posterior plots in sashimi plot #5

Open kwglam opened 2 years ago

kwglam commented 2 years ago

Hi,

I am using the "samples.csv.gz" file generated by brie (splicing quantification) as a "miso_files" input for the sashimi plot. However, no posterior plot is generated. You showed in the 'https://github.com/huangyh09/briekit/blob/master/sashimi_plot/settings/sashimi_settings_brie.txt' file that it is possible to do so. Any idea why?

Gabriel

huangyh09 commented 2 years ago

Hi Gabriel,

Thanks for the issue. Could you share the log (warnings/errors)? Can't figure it out immediately.

Yuanhua

kwglam commented 2 years ago

Hi Yuanhua,

Thanks for your reply. 'Posterior plot failed' is the message that I get. Sashimi plots are fine but no posterior plots on the right panel. My guess is the script that you shared in github is different from the one you used to generate Fig. 4c in the BRIE paper, https://genomebiology.biomedcentral.com/articles/10.1186/s13059-017-1248-5#Abs1.

Any chance if you could kindly share the script again? Thanks!

Gabriel

huangyh09 commented 2 years ago

Hi Gabriel,

Thanks for the log. It looks from this line: https://github.com/huangyh09/briekit/blob/master/sashimi_plot/plot_utils/plot_gene.py#L289

Could you double check if the "miso_prefix" and "miso_files" are all correct? They mean the brie prefix/files here (not a good inherit I admit). If the file can't be found in L274, it will be skipped and return the above log.

This repo is already the latest version and the one we used for the figures. We also reproduced it in a protocol paper, with this tutorial: https://github.com/huangyh09/brie/blob/master/examples/gastrulation/brie_sashimi.sh#L22 But unfortunately, we didn't keep the raw bam files anymore and it needs to be downloaded again with the bash file.

Yuanhua

kwglam commented 2 years ago

Yes, the brie prefix/files are correct. But I should point out that the brie files are pointing to the "samples.csv.gz" files, while the miso files in the original miso 'sashimi_plot_settings.txt' file are pointing to a folder containing a list of chr folders. My guess is this is the reason why posterior plots are not working. I am wondering if you have changed the script to read 'sample.csv.gz' files in your paper instead. Thx!!

huangyh09 commented 2 years ago

Thanks. If memory is correct, I didn't have any customised scripts for generating figures. This repo should be up to date, as also for keeping records.

Yuanhua