huawei-cloudnative / ci-bot

Github CI robot
Apache License 2.0
8 stars 13 forks source link

/assign only considers the last assignment if multiple assignments are done in one comment. #18

Closed anvithks closed 5 years ago

anvithks commented 5 years ago

What is the Issue?
If I try to assign multiple people to a PR by using the following:

/assign xyz  

/assign abc

Only abc gets assigned to the PR.

How can the issue be reproduced?

  1. Create a new PR.
  2. In a new comment try to assign multiple users by entering a /assign command on new lines.
  3. The bot only picks up the second assignment.

What is the expected output?
Every /assign should be considered and processed in the order of assignment.

m1093782566 commented 5 years ago

cc @pavan187

pavan187 commented 5 years ago

What is the Issue? If I try to assign multiple people to a PR by using the following:

/assign xyz  

/assign abc

Only abc gets assigned to the PR.

How can the issue be reproduced?

  1. Create a new PR.
  2. In a new comment try to assign multiple users by entering a /assign command on new lines.
  3. The bot only picks up the second assignment.

What is the expected output? Every /assign should be considered and processed in the order of assignment.

@anvithks , At the moment, we are supporting multiple assignee by doing following format

/assing @xxx, @yyy, @zzz format.

the below format support is not there at the moment /assign @xyz /assign @abc

May be we can take this as a enhancement for /assign in the future.

For now you can add multiple assignee by following format. /assign @xyz @abc

m1093782566 commented 5 years ago

We should add the support.

BTW, k8s-ci-robot support this feature as well.