search

huawei-cloudnative / ci-bot

Github CI robot
Apache License 2.0
8 stars 13 forks source link

[CI-BOT] Code changes for AddAssignee,RemoveAssignee for PR and Issue Comments #2

Closed swx457056 closed 5 years ago

swx457056 commented 5 years ago

This PR Fixes: #4

m1093782566 commented 5 years ago

After going through the codes, I feel I am reviewing the kubernetes/test-infra - it should have many License issues. Please keep in mind that it's a Huawei project and we can learn something from kubernetes but it does not mean we can copy anything from kubernetes.

cc @skdwriting @rohitsardesai83

m1093782566 commented 5 years ago

@swx457056 any updates for the review comments?

swx457056 commented 5 years ago

@m1093782566 , will raise PR for AddAssignee and RemoveAssignee, based on the Huawei-PaaS/CI-Bot code.

m1093782566 commented 5 years ago

@swx457056

Thanks for response, but would you please fix the review comments first?

BTW, @edisonxiang will help this project out as well.

swx457056 commented 5 years ago

@m1093782566 , Please review the code changes we addressed for review comments given. Please let us know your commnets on the code changes

m1093782566 commented 5 years ago

@swx457056 Thanks for prompt reply, I jut throw some more comments there.

sids-b commented 5 years ago

@m1093782566 we can plan to bring the bot online for kubeedge once this PR is merged ? we can upgrade the bot for each new feature we add. Also any suggestions for License Head in this project ?

m1093782566 commented 5 years ago

we can plan to bring the bot online for kubeedge once this PR is merged

CI robot can be online once it has basic functionalities.

m1093782566 commented 5 years ago

For License HEAD, I have no good idea now. What about Huawei Authors with Apache 2 License for now? When this project is mature enough, we can transfer it to kubeedge org and then use kubeedge's license?

sids-b commented 5 years ago

@swx457056 also rebase the fork to latest.

sids-b commented 5 years ago

For License HEAD, I have no good idea now. What about Huawei Authors with Apache 2 License for now? When this project is mature enough, we can transfer it to kubeedge org and then use kubeedge's license?

I am not sure if we can change license straightaway. Maybe start with kubeedge authors only ?

m1093782566 commented 5 years ago

I am not sure if we can change license straightaway. Maybe start with kubeedge authors only ?

OK.

swx457056 commented 5 years ago

@m1093782566 , I have reworked on the comments and updated the changes, please review.

m1093782566 commented 5 years ago

After many rounds of review, I think we can merge this PR now. Let's deploy the robot and have it online!