huawei-cloudnative / firmament

The Firmament cluster scheduling platform
http://www.firmament.io
Apache License 2.0
19 stars 9 forks source link

void methods are not testable. so we need to make then to return error code #38

Open Suresh-Babu-K opened 5 years ago

Suresh-Babu-K commented 5 years ago

void methods are not testable. so we need to make then to return error code

this look challenging as we did not designed the whole code as testable one.

void CpuCostModel::PrepareStats(FlowGraphNode* accumulator) .. if this would have returned an error code we know that action is completed properly .