search

huawei-noah / SMARTS

Scalable Multi-Agent RL Training School for Autonomous Driving
MIT License
909 stars 184 forks source link

Test `test_multiple_renderers` causes segmentation fault #1175

Open Gamenot opened 2 years ago

Gamenot commented 2 years ago

BUG REPORT

High Level Description The test smarts/core/tests/test_renderers.py::test_multiple_renderers causes a segmentation fault when run.

SMARTS version 0.4.18

Previous associated issues [Link any associated issues here]

Steps to reproduce the bug

$ ##Run
$ pip install -e .[test,camera-obs]
$ pytest smarts/core/tests/smarts/core/tests/test_renderers.py::test_multiple_renderers`

Resulting and expected behaviour A "Segment fault" is thrown. Test should pass without issue.

Error logs and screenshots See error log: https://github.com/huawei-noah/SMARTS/runs/4490851081?check_suite_focus=true#step:5:253

System information

Impact [If known] It appears as if it may not be possible to use multiple Renderers on the same process.

sah-huawei commented 2 years ago

fwiw, I can't reproduce this locally. Also, I wanted to double-check about which test shows this. In the "High Level Description" section it says test_renderers.py but in the "Steps to Reproduce" it says test_python_version.py. (Both test files currently pass for me locally.)

Gamenot commented 2 years ago

Sorry, that was my mistake. The reproduction should be in test_renderers.py. I have a more intensive test running and it does not seem to be catching anything. As always it could be an issue with the Github workers.

sah-huawei commented 2 years ago

If there's a way to do this on the Github worker, it might be worth checking:

from panda3d.core import Thread
Thread.isThreadingSupported()

This should be True when Panda has been compiled with threading support. (I checked this locally and mine has.)

Gamenot commented 2 years ago

Another test has failed the same way: https://github.com/huawei-noah/SMARTS/runs/4523507673?check_suite_focus=true#step:5:253