search

huawei-noah / SMARTS

Scalable Multi-Agent RL Training School for Autonomous Driving
MIT License
943 stars 190 forks source link

Agent can drive offroad without triggering done. #1797

Open Gamenot opened 1 year ago

Gamenot commented 1 year ago

Agent can drive offroad without triggering done.

+ `Metrics` verifies the environment suitability during instantiation. 
+ Here, `Metrics` cannot be used on an environment which has an agent with `DoneCriteria(off_road=False)`. 
+ On another comment, since environment suitability is checked by `Metrics`, I thought we don't have to call it `CompetitionMetrics`.

https://github.com/huawei-noah/SMARTS/blob/5d2dff7e0a91454cfd4722481ebfe5d99a298b29/smarts/env/gymnasium/wrappers/metrics.py#L276-L307

_Originally posted by @Adaickalavan in https://github.com/huawei-noah/SMARTS/pull/1793#discussion_r1081731852_

Gamenot commented 1 year ago

We should check the exact conditions that an agent will be considered offroad and why it might skip making that agent done.