search

huawei-noah / SMARTS

Scalable Multi-Agent RL Training School for Autonomous Driving
MIT License
954 stars 190 forks source link

Social agent name should map to mission. #2008

Open Gamenot opened 1 year ago

Gamenot commented 1 year ago

This should make Scenario.missions[] contain the social agent name instead of the mangled id.

Gamenot commented 1 year ago

It appears like this change causes a problem with combining groups of social agents.

The agent mission ids are marked like "social-actor-"+<group id>+<actor id>.

I can strip away the prefix "social-actor-" but then group id is still integrated. This is necessary because missions are combined between groups which may share the underlying actor name.

Gamenot commented 1 year ago

@Adaickalavan

Adaickalavan commented 1 year ago

Given this case, I have now resorted to searching for the vehicles of interest in Scenario.missions.keys() using a substring match criteria. Hence, this PR may be closed. Thanks.

Gamenot commented 1 year ago

There is some consideration still here that the actor names should still be exactly named and unique between groups considering the actors are being combined across groups.