huawei-noah / SMARTS

Scalable Multi-Agent RL Training School for Autonomous Driving
MIT License
956 stars 190 forks source link

[Feature request] Remove `wait_to_hijack_limit_s` from `EntryTactic` to prevent unexpected issues #2050

Open qianyi-sun opened 1 year ago

qianyi-sun commented 1 year ago

Motivation

The wait_to_hijack_limit_s has become redundant with the condition field of the TrapEntryTactic.

Proposal

Supply the start time condition through condition. This should allow for the choice between waiting a number of steps or waiting until a given simulation time.

Alternatives

None

Additional context

This is a follow-up to #1965 which attempts to implement logical (and temporal) conditions that describe how to select vehicles from scenario studio.