huawei-noah / SMARTS

Scalable Multi-Agent RL Training School for Autonomous Driving
MIT License
909 stars 184 forks source link

[Bug Report] units of TTC calculation in custom_observations.py #2154

Open DailyL opened 1 month ago

DailyL commented 1 month ago

Since VehicleObservation already provides the speed in m/s, why are we converting it from km/h to m/s again? Am I missing something?

https://github.com/huawei-noah/SMARTS/blob/98226f1e61058d8c7e2cc571eb395cd1ccfaf9ec/smarts/env/custom_observations.py#L322