search

huawei-noah / trustworthyAI

Trustworthy AI related projects
Apache License 2.0
958 stars 216 forks source link

To use a dedicates namespace for the logging. #152

Open corradomio opened 4 months ago

corradomio commented 4 months ago

To use the Python 'logging' package to write logs is good. BUT it is BETTER (and simple) to use a dedicated namespace, for example "castle.algorithm." for the algorithms, and "castle.general" or similar names for the generic parts of the code, and NOT the 'root' namespace. This because if the library is used in a more complex application, it permits to decide which logs to select.

shaido987 commented 4 months ago

Thanks for the suggestion! The logging is a bit disorganized right now and could use a look-over to consistently use getLogger(__name__) or similar, and follow the same format everywhere.

Let us know if you are interested in making a PR for this issue!