search

huaweicloud / huaweicloud-service-broker

Huawei Cloud Service Broker
Apache License 2.0
18 stars 12 forks source link

On Openshift, Using the service name from ClusterServiceBroker controller #70

Closed yeplaa closed 5 years ago

yeplaa commented 5 years ago

Proposal

Currently, from the doc it is appropriate to use the service IP to set the key url value into the service-broker.yaml file. Bellow the extract of README :

Firstly you need to get the service ClusterIP and Port which are created by Step 3.

$ oc get svc | grep service-broker
$ vi service-broker.yaml

Update the key url value in service-broker.yaml file by the service ClusterIP and Port.

If the openshift deployment is removed then recreate, the IP of type CLUSTER-IP is updated.

I think it's better to use the service name into the key url value.

For example : 

url: http://service-broker.huaweicloud-service-broker.svc.cluster.local:12345

service-broker : name of service huaweicloud-service-broker : name of project/namespace. In my case, i used the huaweicloud-service-broker project for the huawei deployment svc.cluster.local : domain name used by defaut to access to service.

Using the FQDN of service, the clusterServiceBroker Controller can resolve the DNS of service localized in a project/namespace.

What do you think?

Loïc

edisonxiang commented 5 years ago

Great suggestion. Thanks @yeplaa

edisonxiang commented 5 years ago

The document and deployment yaml are updated by this commit.

yeplaa commented 5 years ago

Thank's @edisonxiang for your commit :)