huaweicloud / terraform-provider-huaweicloud

Terraform HuaweiCloud provider
https://www.terraform.io/docs/providers/huaweicloud/
Mozilla Public License 2.0
213 stars 160 forks source link

chore(cc): add CheckDeleted to CC resource deletion #5563

Closed profoundwu closed 1 month ago

profoundwu commented 1 month ago

What this PR does / why we need it: add CheckDeleted to CC resource deletion Which issue this PR fixes: (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged) fixes #xxx

Special notes for your reviewer:

Release note:

1. add CheckDeleted to CC resource deletion

PR Checklist

make testacc TEST="./huaweicloud/services/acceptance/cc" TESTARGS="-run TestAccAuthorization_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/cc -v -run TestAccAuthorization_basic -timeout 360m -parallel 4
=== RUN   TestAccAuthorization_basic
=== PAUSE TestAccAuthorization_basic
=== CONT  TestAccAuthorization_basic
--- PASS: TestAccAuthorization_basic (57.51s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cc        57.585s

make testacc TEST="./huaweicloud/services/acceptance/cc" TESTARGS="-run TestAccBandwidthPackage_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/cc -v -run TestAccBandwidthPackage_basic -timeout 360m -parallel 4
=== RUN   TestAccBandwidthPackage_basic
=== PAUSE TestAccBandwidthPackage_basic
=== CONT  TestAccBandwidthPackage_basic
--- PASS: TestAccBandwidthPackage_basic (47.15s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cc        47.258s

make testacc TEST="./huaweicloud/services/acceptance/cc" TESTARGS="-run TestAccCentralNetwork_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/cc -v -run TestAccCentralNetwork_basic -timeout 360m -parallel 4
=== RUN   TestAccCentralNetwork_basic
=== PAUSE TestAccCentralNetwork_basic
=== CONT  TestAccCentralNetwork_basic
--- PASS: TestAccCentralNetwork_basic (66.72s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cc        66.788s

make testacc TEST="./huaweicloud/services/acceptance/cc" TESTARGS="-run TestAccCentralNetworkAttachment_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/cc -v -run TestAccCentralNetworkAttachment_basic -timeout 360m -parallel 4
=== RUN   TestAccCentralNetworkAttachment_basic
=== PAUSE TestAccCentralNetworkAttachment_basic
=== CONT  TestAccCentralNetworkAttachment_basic
--- PASS: TestAccCentralNetworkAttachment_basic (252.79s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cc        252.852s

make testacc TEST="./huaweicloud/services/acceptance/cc" TESTARGS="-run TestAccCentralNetworkConnectionBandwidthAssociate_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/cc -v -run TestAccCentralNetworkConnectionBandwidthAssociate_basic -timeout 360m -parallel 4
=== RUN   TestAccCentralNetworkConnectionBandwidthAssociate_basic
=== PAUSE TestAccCentralNetworkConnectionBandwidthAssociate_basic
=== CONT  TestAccCentralNetworkConnectionBandwidthAssociate_basic
--- PASS: TestAccCentralNetworkConnectionBandwidthAssociate_basic (412.09s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cc        412.176s

make testacc TEST="./huaweicloud/services/acceptance/cc" TESTARGS="-run TestAccCentralNetworkPolicy_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/cc -v -run TestAccCentralNetworkPolicy_basic -timeout 360m -parallel 4
=== RUN   TestAccCentralNetworkPolicy_basic
=== PAUSE TestAccCentralNetworkPolicy_basic
=== CONT  TestAccCentralNetworkPolicy_basic
--- PASS: TestAccCentralNetworkPolicy_basic (129.73s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cc        129.786s

make testacc TEST="./huaweicloud/services/acceptance/cc" TESTARGS="-run TestAccCentralNetworkPolicyApply_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/cc -v -run TestAccCentralNetworkPolicyApply_basic -timeout 360m -parallel 4
=== RUN   TestAccCentralNetworkPolicyApply_basic
=== PAUSE TestAccCentralNetworkPolicyApply_basic
=== CONT  TestAccCentralNetworkPolicyApply_basic
--- PASS: TestAccCentralNetworkPolicyApply_basic (145.95s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cc        146.028s

make testacc TEST="./huaweicloud/services/acceptance/cc" TESTARGS="-run TestAccCloudConnection_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/cc -v -run TestAccCloudConnection_basic -timeout 360m -parallel 4
=== RUN   TestAccCloudConnection_basic
=== PAUSE TestAccCloudConnection_basic
=== CONT  TestAccCloudConnection_basic
--- PASS: TestAccCloudConnection_basic (26.73s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cc        26.798s

 make testacc TEST="./huaweicloud/services/acceptance/cc" TESTARGS="-run TestAccGCB_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/cc -v -run TestAccGCB_basic -timeout 360m -parallel 4
=== RUN   TestAccGCB_basic
=== PAUSE TestAccGCB_basic
=== CONT  TestAccGCB_basic
--- PASS: TestAccGCB_basic (25.57s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cc        25.632s

make testacc TEST="./huaweicloud/services/acceptance/cc" TESTARGS="-run TestAccGCBAssociate_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/cc -v -run TestAccGCBAssociate_basic -timeout 360m -parallel 4
=== RUN   TestAccGCBAssociate_basic
=== PAUSE TestAccGCBAssociate_basic
=== CONT  TestAccGCBAssociate_basic
--- PASS: TestAccGCBAssociate_basic (541.05s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cc        541.107s

 make testacc TEST="./huaweicloud/services/acceptance/cc" TESTARGS="-run TestAccInterRegionBandwidth_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/cc -v -run TestAccInterRegionBandwidth_basic -timeout 360m -parallel 4
=== RUN   TestAccInterRegionBandwidth_basic
=== PAUSE TestAccInterRegionBandwidth_basic
=== CONT  TestAccInterRegionBandwidth_basic
--- PASS: TestAccInterRegionBandwidth_basic (60.64s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cc        60.696s

make testacc TEST="./huaweicloud/services/acceptance/cc" TESTARGS="-run TestAccNetworkInstance_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/cc -v -run TestAccNetworkInstance_basic -timeout 360m -parallel 4
=== RUN   TestAccNetworkInstance_basic
=== PAUSE TestAccNetworkInstance_basic
=== CONT  TestAccNetworkInstance_basic
--- PASS: TestAccNetworkInstance_basic (133.15s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cc        133.225s
houpeng80 commented 1 month ago

/lgtm

Jason-Zhang9309 commented 1 month ago

/lgtm /approve