Open DeveloperSantosh opened 2 years ago
There's definitely a bug in the library .
We have a test for this, so it is likely that the API changed and the library needs updating.
Just had the same issue. I updated to the newest version v1.319
which just came out this month. Strange, because I still see new updates to this library but this bug seems pretty simple and is years old. Is this library only partially being maintained?
@mgroth0
this bug seems pretty simple and is years old. Is this library only partially being maintained?
Hm, https://github.com/hub4j/github-api/graphs/commit-activity indicates a steady stream of commits. Perhaps you'd like to add your name to the list people who have contributed to this project?
@bitwiseman sorry that my comment came off a bit snarky. I didn't mean to.
I think that the amount of setup (with setting up credentials and to do all the proper testing) is bit much for me. I made my request with HTTP directly and it works for my use case, so I no longer need this.
However, I can say my idea in case it helps.
It is about this line.
req.setHeader("If-Modified-Since", lastModified);
It seems that lastModified
might be null the first time, and I wonder if github doesn't like the null or blank header value. I wonder if we just tried this:
if (lastModified!=null) {
req.setHeader("If-Modified-Since", lastModified);
}
@mgroth0 My apologies for my return-snarking. 😄 Thanks for taking time to add some details/suggestion. When someone has the time to look at this it will help them get started.
While retrieving notifications it's throwing errors described below for the code listed below.
**The line of code where I am getting error is
I am not sure about the real cause of it but it's maybe caused due to the 'null' value passing in lastModified variable in org.kohsuke.github.GHNotificationStream class line number: 107 of below snippet,
Expected behavior A GHThread value should be given in return but throwing HttpException indicating the value of the header "If-Modified-Since" is null.