hub4j / github-api

Java API for GitHub
https://github-api.kohsuke.org/
MIT License
1.12k stars 718 forks source link

Only try to strip upload url 'helpful garbage' if it is present #1799

Closed SuperKael closed 4 months ago

SuperKael commented 4 months ago

This library is mostly compatible with the Gitea API, which although somewhat incidental, is nonetheless wonderful. However, it fails to upload release assets due to this one small and easily-fixed issue. Adding this check does not in any way obstruct the normal use of the GitHub API.

Description

The GHRelease.uploadAsset method substrings the upload URL to grab the URL before the 'helpful garbage' provided by GitHub, which begins with a '{' character. However, if the upload URL does not have a '{' character in it for some reason (such as the API actually being provided by Gitea, not GitHub), this method throws an exception. This change simply adds a check to avoid this exception.

Before submitting a PR:

When creating a PR:

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.69%. Comparing base (be00e51) to head (a1499d7). Report is 11 commits behind head on main.

Files Patch % Lines
src/main/java/org/kohsuke/github/GHRelease.java 66.66% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1799 +/- ## ============================================ + Coverage 80.64% 80.69% +0.04% - Complexity 2322 2330 +8 ============================================ Files 219 220 +1 Lines 7027 7049 +22 Branches 371 372 +1 ============================================ + Hits 5667 5688 +21 Misses 1128 1128 - Partials 232 233 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.