hub4j / github-api

Java API for GitHub
https://github-api.kohsuke.org/
MIT License
1.14k stars 727 forks source link

Fix visibility of getters in GHRequestedAction #1824

Closed yrodiere closed 6 months ago

yrodiere commented 6 months ago

Description

GHRequestedAction has getters, but those getters have package-private (default) visibility, and thus are unusable.

This changes the visibility of those getters to public.

Looks like this part of the API is untested, and sorry, I didn't really have time to add new tests, but I figured this at least nudges things the right way :shrug:

Before submitting a PR:

When creating a PR:

yrodiere commented 6 months ago

I applied your suggestions, thanks.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.64%. Comparing base (092d254) to head (4bdf1fe). Report is 9 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1824 +/- ## ========================================= Coverage 80.64% 80.64% Complexity 2354 2354 ========================================= Files 223 223 Lines 7185 7185 Branches 395 395 ========================================= Hits 5794 5794 Misses 1145 1145 Partials 246 246 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.