hub4j / github-api

Java API for GitHub
https://github-api.kohsuke.org/
MIT License
1.12k stars 718 forks source link

Provide support for External Group operations #1835

Closed mestebangutierrez closed 1 month ago

mestebangutierrez commented 3 months ago

Description

Provide support for External Group operations, in particular:

Fixes https://github.com/hub4j/github-api/issues/1828

Before submitting a PR:

When creating a PR:

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.03%. Comparing base (c5ce1f6) to head (c2ac4b0). Report is 9 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1835 +/- ## ============================================ + Coverage 80.64% 81.03% +0.38% - Complexity 2358 2409 +51 ============================================ Files 225 233 +8 Lines 7203 7344 +141 Branches 395 399 +4 ============================================ + Hits 5809 5951 +142 + Misses 1149 1148 -1 Partials 245 245 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mestebangutierrez commented 2 months ago
mestebangutierrez commented 2 months ago

@bitwiseman, is anything else required on my side before continuing the contribution process?

jbenaventem commented 1 month ago

@bitwiseman Please take a moment to review this Pull Request. It contains important changes that could significantly improve the GitHub Enterprise accounts use. If you notice any issues or have any concerns, do not hesitate to comment. Your feedback is greatly appreciated.

mestebangutierrez commented 1 month ago

Very well tested and implemented. Great job!

A few adjustments and renames needed.

@bitwiseman, first of all, thanks for the review!

I've done all the requested changes, addressing each of them in its own commit.

I've also answered to all the conversations, but haven't resolved them. I let that to you in case you consider that that changes I've done satisfy the request.

Again, thanks for your effort and patience!

mestebangutierrez commented 1 month ago

Rebased from main again.