1885 showed that we haven't been checking the count of all enum values. At the same time I noticed that we do not have UNKNOWN values for all API enum.
Adding new values is not considered a breaking change by GitHub. This has caused hub4j/github-api calls to start failing unexpectedly in the the past - the new value is not recognized and we throw an exception during deserialization. No good.
We need to add UNKNOWN to all enum types that are returned from GitHub and enforce it. The test will include an exclude list to allow enum types only used during sending but not retrieving data.
1885 showed that we haven't been checking the count of all enum values. At the same time I noticed that we do not have
UNKNOWNvalues for all APIenum.Adding new values is not considered a breaking change by GitHub. This has caused
hub4j/github-apicalls to start failing unexpectedly in the the past - the new value is not recognized and we throw an exception during deserialization. No good.We need to add
UNKNOWNto allenumtypes that are returned from GitHub and enforce it. The test will include an exclude list to allowenumtypes only used during sending but not retrieving data.