Closed ihrigb closed 1 month ago
Attention: Patch coverage is 98.13084%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 81.29%. Comparing base (
cab9bbb
) to head (f3e03d3
).
Files | Patch % | Lines |
---|---|---|
...main/java/org/kohsuke/github/GHRepositoryRule.java | 98.05% | 1 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@bitwiseman I will take care of your suggestions.
As of the Parameter vs. Polymorphism topic I had to thoughts about it as well. The parameter way turned out to be more flexible, if GitHub does any change to the API (not sure, if that would happen with the current version being almost two years old). Using polymorphism would result in weird Java code with instanceof
stuff and casting types. Happy to discuss this either way.
Description
Add methods to get all active rules for a branch.
Before submitting a PR:
@link
JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .mvn -D enable-ci clean install site
locally. If this command doesn't succeed, your change will not pass CI.main
. You will create your PR from that branch.When creating a PR: