Closed jonesbusy closed 1 month ago
Attention: Patch coverage is 92.85714%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 81.32%. Comparing base (
3c4d80c
) to head (6493b2c
).
Files | Patch % | Lines |
---|---|---|
src/main/java/org/kohsuke/github/GHBranchSync.java | 87.50% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Sure thanks, I will try to add a new model for the sync response and perform some assertion on it
I've added the GHBranchSync
model and return it
I've also added a negative test when the API return a non-200 status code (for example 422 when the repo is not a fork)
Apparently something wrong with javadoc. I will take a look
Should be fixed, can you restart the workflows please ?
Hi @bitwiseman Sorry for the ping, but where you able to review again this PR ?
It's also update with the default branch
Thanks!
Thanks for the merge @bitwiseman. Sorry to ping you directly (again) but is there a release soon including this feature ?
I'm asking because we are approaching the end of the Google Summer of Code on our project https://github.com/jenkinsci/plugin-modernizer-tool and would be great that we can include the new release on our delivery
The fork sync is quiet critical on our project to avoid opening PRs from outdated forks.
Thanks for your consideration 😃
I'll do a release today.
Description
Add support for fork sync branch
Fixing https://github.com/hub4j/github-api/issues/1626
Added two wiremock test and tested a SNAPSHOT version in a WIP PR https://github.com/jenkinsci/plugin-modernizer-tool/pull/141
I confirm this work by enabling logs and ensuring my fork is sync directly on GitHub
Before submitting a PR:
@link
JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .mvn -D enable-ci clean install site
locally. If this command doesn't succeed, your change will not pass CI.main
. You will create your PR from that branch.When creating a PR:
API is https://docs.github.com/en/rest/branches/branches?apiVersion=2022-11-28#sync-a-fork-branch-with-the-upstream-repository
Code is covered 100%