Open ajmalab opened 4 days ago
@ajmalab
What is the JSON that is returned by the call to getRepo
and getRef()
?
The library uses the returned urls to calculate the endpoint to call for delete()
.
It sounds like you're trying to run local test server. To do that you need to modify the response body to replace api.github.com with localhost:8080
.
We use GitHubApiResponseTransformer
:
Which then calls mapToMockGitHub
which has a bunch of body string replacements:
Describe the bug Calling
getRef().delete()
does not respect the base URL set in .withEndpoint() when creating the OAuth client. It usesapi.github.com
by default. While this would work in production, it blocks the ability to test this endpoint using local mock servers.To Reproduce Steps to reproduce the behavior:
https://api.github.com
and nothttp://localhost:8080
.Expected behavior The
getRef().delete()
method should respect the base URL passed in viawithEndpoint()
like the other chained methods ofgetRepository()
.Additional context Library version: 1.321