search

hube12 / DecompilerMC

This repository allows you to decompile any minecraft version that was published after 19w36a without any 3rd party mappings, you just need to execute the script or the executable (see releases)! Thanks mojang to have published proguard mappings
Other
642 stars 54 forks source link

Make main.py executable #34

Closed dhouck closed 3 years ago

dhouck commented 3 years ago

As in the title

dhouck commented 3 years ago

Wow, github does not display mode changes well. This is not an empty file and I did not empty the file; the diff is empty because I didn't change the content.

hube12 commented 3 years ago

Setting a chmod or suid bit is not a valid PR as git will strip it down anyway. This should be done per user by using chmod +x main.py locally

dhouck commented 3 years ago

Git does store the executable bit, although it doesn't store most of the rest of the perms.

On GitHub, this PR has: image Note the 100644 → 100755.

On git CLI, I have

commit f2ab052 (HEAD -> executable-perms, origin/executable-perms, master)
Author:     Daniel Houck <GitHub@DRHouck.me>
AuthorDate:  Thu 2021-06-03 4:04:21 -0500
Commit:     Daniel Houck <GitHub@DRHouck.me>
CommitDate:  Thu 2021-06-03 4:04:21 -0500

    Make main.py executable

diff --git a/main.py b/main.py
old mode 100644
new mode 100755

I don't know if it'll eat it if you commit from Windows but I expect not.

hube12 commented 3 years ago

My point was my system whether I am on windows on linux will strip the perms bit. I don't consider this a valid PR because you should not push executable files on source, I could add it as a release tho