search

hube12 / Minemap

An efficient map viewer for Minecraft seed in a nice GUI with utilities without ever needing to install Minecraft.
https://minemap.app
MIT License
166 stars 10 forks source link

Bug: Cannot take screenshot of a grid containing a zombie village #14

Closed rjdoerz closed 1 year ago

rjdoerz commented 1 year ago

Basic issue: If you have the icon for villages enabled, any grid on the map that contains a zombie village icon will not let you take a screenshot using the built-in screenshot function. Normal villages work fine. It's just zombie villages that are a problem. image

More detail: Here is a screen snip I took of a map I have. image I colored in one grid that contains a zombie village icon. If any part of that grid is being displayed on screen, your program's screenshot function will not work. Even if it's only 1 pixel in frame.

If you disable the village icons from appearing on the map, then you are able to screenshot again. I don't know if this issue exists for other icons as I'm only using a limited selection of enabled icons.

Recreation: Version 1.0.24 Seed I'm using: 3971198378293864095 [1.16.1] Example of zombie village: (1337, 6713)

hube12 commented 1 year ago

Very interesting issue indeed, I will look into it ;)

hube12 commented 1 year ago

Fixed in b42a8fbcaeddd0ca140335028f10d9b4cc15f4a1

The gist: Java doesn't set the clipping when creating a new graphic object and thus if I do that from an image (which has no clipping behavior) then no one will set it ever, thus if I rely on it to display stuff then it will fail.

Fix: Add a fake clipping region after creating my graphics from my bufferedImage