Correct error message in _beforeStep

hubidu / bifrost-io

Create awesome E2E Reports. For codeceptjs and others.

6 stars 4 forks source link

Correct error message in _beforeStep #10

Closed iredchuk closed 5 years ago

iredchuk commented 5 years ago

Also allow empty string for selector

hubidu commented 5 years ago

Sorry, I don't understand. How and why should an empty string locator be highlighted?

I'll do something else to make the message go away.

iredchuk commented 5 years ago

OK, if a previous function is only for highlighting, then you are right, we should not do it. But I would still not log the message for empty strings since we intentionally use them, and also correct the log message.

hubidu commented 5 years ago

Just published 0.6.18. Message should no longer appear.

NOTE: npm usually takes some time until version is available.

iredchuk commented 5 years ago

Thanks