hubiinetwork / hubii-core

The home of hubii core (aka Omphalos UI), the reference desktop app for nahmii
GNU General Public License v3.0
21 stars 4 forks source link

Unhandled network exception #660

Closed liamaharon closed 5 years ago

liamaharon commented 5 years ago

Sometimes an unhandled network error will cause a system popup dialog.

screenshot 2018-12-18 at 12 08 52

Seems to be most reproducible when waking a system from sleep(?)

liamaharon commented 5 years ago

dev stacktrace:

Unhandled Promise Rejection
Error: Request has been terminated
Possible causes: the network is offline, Origin is not allowed by Access-Control-Allow-Origin, the page is being unloaded, etc.
    at Request.crossDomainError (webpack-internal:///./node_modules/superagent/lib/client.js:621:13)
    at XMLHttpRequest.xhr.onreadystatechange (webpack-internal:///./node_modules/superagent/lib/client.js:703:19)
liamaharon commented 5 years ago

Appears to be an issue in the SDK. Will open a PR to ignore this particular exception until it's fixed upstream. https://github.com/hubiinetwork/nahmii-sdk/issues/67

liamaharon commented 5 years ago

PR opened for a proper solution upstream, we can remove the band-aid fix once it's merged and we've updated our dependencies https://github.com/hubiinetwork/nahmii-sdk/pull/75