1.2.6 - Githubissues

hubiinetwork / hubii-core

The home of hubii core (aka Omphalos UI), the reference desktop app for nahmii

GNU General Public License v3.0

21 stars 4 forks source link

1.2.6 #786

Closed katat closed 5 years ago

katat commented 5 years ago

[x] Deprecate trimDecimals() and use NumericText component to format the numbers instead. (fix #785)
[x] Remove the pending settlement tx from local storage if it has been overridden by the other tx with the same nonce

katat commented 5 years ago

@morfj It is a UI component introduced earlier. https://github.com/hubiinetwork/hubii-core/blob/master/src/components/ui/NumericText/index.js

The function trimDecimals is currently doing the same formating work on top of the NumericText component. Deprecating the use of the trimDecimals will allow the values being formated by the NumbericText directly.

katat commented 5 years ago

@jonbern Sorry. There are some minor updates after your approval. Now it is ready for another review. Thanks.