hubiinetwork / nahmii-contracts

Smart contracts for 1st generation Nahmii 2nd layer scaling solution for Ethereum
16 stars 12 forks source link

Enable settlement of payment whose DSC has 0 stage amount #449

Closed jijordre closed 5 years ago

jijordre commented 5 years ago

Description

As currently implemented it is possible to start a DSC on a payment and propose a stage amount of 0. However, when settling this payment the settlement call fails. The reason being that ClientFund.stage() is set to revert with stage amount that is not strictly positive.

This issue describes the enablement of settlement of payment whose DSC proposes a stage amount of 0. This can be done by only calling ClientFund.stage() when stage amount is strictly positive.

Definition of done

Details & Questions

Depends on

jijordre commented 5 years ago

Closed by #448.