search

hubipe / QrPaymentHU

Library for generating Hungarian QR code payments
MIT License
2 stars 0 forks source link

Use rikudou/iban #1

Closed RikudouSage closed 2 years ago

RikudouSage commented 2 years ago

Instead of the bundled implementation, you could use the decoupled rikudou/iban and optionally provide an implementation of the interface for some local format.

Also you may move your Hungarian adapter from this package to the rikudou/iban package to make it available even in contexts outside QR payments.

hubipe commented 2 years ago

Thanks, I've decoupled the IBAN interface (https://github.com/hubipe/QrPaymentHU/commit/f792d273c846088cd6f6cb70ef6d06450f9c46a3).

Concerning the Hungarian adapter, I have it prepared, but have to write some tests firsts (hopefully will pull-request it by end of the week).

hubipe commented 2 years ago

Bundled implementation of the Hungarian IBAN adapter and validator successfully moved to rikudou/IBAN, thus closing the issue.