search

hubmapconsortium / ccf-asct-reporter

HRA ASCT+B Reporter
https://hubmapconsortium.github.io/ccf-asct-reporter/
10 stars 5 forks source link

Bug: AS not connected to CT in visualization #354

Open emquardokus opened 2 years ago

emquardokus commented 2 years ago

Can someone look into this?

This is a new table and the person generating it reported this problem.

This should work, but I have not yet tried to replicate.

Begin forwarded message:

From: "Fisher, Stephen A" [safisher@sas.upenn.edu](mailto:safisher@sas.upenn.edu) Subject: [External] Bug in reporter? Date: March 22, 2022 at 3:55:17 PM EDT To: HuBMAP CCF Info [infoccf@indiana.edu](mailto:infoccf@indiana.edu) Cc: Kathleen O'Neill [Kathleen.O'neill2@pennmedicine.upenn.edu](mailto:Kathleen.O'neill2@pennmedicine.upenn.edu)

This message was sent from a non-IU address. Please exercise caution when clicking links or opening attachments from external sources.

Hi,

I noticed the Reporter ignores links when cells are assigned to structures that are not leaves of the anatomical tree. The attached pictures illustrate the problem using the Uterus v1.0 ASCT+B table.

Cheers, Stephen

Stephen Fisher, PhD Biology Department University of Pennsylvania

Screen Shot 2022-03-22 at 7.47.04 PM.pngScreen Shot 202

Screen Shot 2022-03-22 at 7 47 04 PM

2-03-22 at 7.47.09 PM.pn Screen Shot 2022-03-22 at 7 47 09 PM g

bherr2 commented 2 years ago

CC: @safisher

This may be a conceptual issue too (CC @katyb ) that we need to go over. So, yes, only leaf nodes draw to the CTs. The left-hand side is a tree and then CT + B columns are added and drawn between the two.

We could work on a naive approach that draws from non-leaf nodes to CT. I do worry it's gonna look wonky, but worth a try to see.