search

hubmapconsortium / ccf-asct-reporter

HRA ASCT+B Reporter
https://hubmapconsortium.github.io/ccf-asct-reporter/
10 stars 5 forks source link

Angular 17 upgrade #804

Closed edlu77 closed 3 weeks ago

github-actions[bot] commented 5 months ago

:rocket: Preview Deploy Report

✅ Successfully deployed preview here

bherr2 commented 5 months ago

What is the alternative to mat table exporter?

bherr2 commented 5 months ago

Looks like maybe it doesn't use it actually. Please verify, but otherwise the build preview looks to be working.

github-actions[bot] commented 5 months ago

:rocket: Preview Deploy Report

✅ Successfully deployed preview here

edlu77 commented 5 months ago

Looks like maybe it doesn't use it actually. Please verify, but otherwise the build preview looks to be working.

It looks to be redundant, think it's safe to just get rid of it.

bherr2 commented 5 months ago

Please fix tests

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 5 months ago

:rocket: Preview Deploy Report

✅ Successfully deployed preview here

bherr2 commented 3 weeks ago

Done in hra-ui repo