hubmapconsortium / ccf-ui

HRA Exploration and Registration User Interfaces

https://apps.humanatlas.io/eui/

MIT License

8 stars 2 forks source link

Add configurations for donors label and button urls #1223

Closed edlu77 closed 5 months ago

edlu77 commented 5 months ago

1220

github-actions[bot] commented 5 months ago

:rocket: Preview Deploy Report Updated

✅ Successfully deployed preview here

bherr2 commented 5 months ago

What kind of speed improvements are you seeing? Test load times with dataSources + use-remote-api=true vs dataSource + use-remote-api=false. Should give you an indication of the speed up we'll receive.

edlu77 commented 5 months ago

What kind of speed improvements are you seeing? Test load times with dataSources + use-remote-api=true vs dataSource + use-remote-api=false. Should give you an indication of the speed up we'll receive.

Was this supposed to be in the other PR? 😅

Anyway I tested it, it doesn't really seem to be making much difference. Takes basically the same amount of time to load as before...

edlu77 commented 5 months ago

Where are the default URL set? Also, need to add documentation to the EMBEDDING.md about the new inputs.

Default URLs are set here: https://github.com/hubmapconsortium/ccf-ui/blob/develop/projects/ccf-organ-info/src/app/modules/link-cards/link-cards.component.ts

The inputs to the web component override buttonUrl

sonarcloud[bot] commented 5 months ago

Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud